Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Tolerate sam failure for my-workflows

See original GitHub issue

Bug Report

Expected behaviour

If SAM is down or giving back 401s, you should still be able to see your own content.

Actual behaviour

https://staging.dockstore.org/api/workflows/shared dies with a 401 This seems to kill https://staging.dockstore.org/api/users/3/workflows from the client side (I see a 499 on the webservice) and then you can’t see your own content.

Relevant errors

webservice_1     | ERROR [2018-07-12 20:42:31,269] io.dockstore.webservice.permissions.sam.SamPermissionsImpl: Error getting shared workflows
webservice_1     | ! io.swagger.sam.client.ApiException: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
webservice_1     | ! <html><head>
webservice_1     | ! <title>401 Unauthorized</title>
webservice_1     | ! </head><body>
webservice_1     | ! <h1>Unauthorized</h1>
webservice_1     | ! <p>This server could not verify that you
webservice_1     | ! are authorized to access the document
webservice_1     | ! requested.  Either you supplied the wrong
webservice_1     | ! credentials (e.g., bad password), or your
webservice_1     | ! browser doesn't understand how to supply
webservice_1     | ! the credentials required.</p>
webservice_1     | ! <hr>
webservice_1     | ! <address>Apache Server at sam.dsde-staging.broadinstitute.org Port 443</address>
webservice_1     | ! </body></html>
webservice_1     | ! 
webservice_1     | ! at io.swagger.sam.client.ApiClient.invokeAPI(ApiClient.java:737)
webservice_1     | ! at io.swagger.sam.client.api.ResourcesApi.listResourcesAndPolicies(ResourcesApi.java:391)
webservice_1     | ! at io.dockstore.webservice.permissions.sam.SamPermissionsImpl.workflowsSharedWithUser(SamPermissionsImpl.java:116)
webservice_1     | ! at io.dockstore.webservice.resources.WorkflowResource.sharedWorkflows(WorkflowResource.java:725)

┆Issue is synchronized with this Jira Bug ┆Issue Number: DOCK-42 ┆Sprint: Backlog ┆Issue Type: Bug

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

coverbeckcommented, Jul 13, 2018

I think there are two issues here:

The shared flows endpoint should return an empty response instead of a 401 if the user has not registered with SAM (working on that one).
I think the client side should handle this more gracefully, although if this is the only case where this happens, then maybe it’s not that urgent. I had already logged that as #1588 .

1reaction

coverbeckcommented, Jul 12, 2018

I was wondering if you get it if your account is not linked to Google. Regardless, I will investigate.

Top Results From Across the Web

Tolerate sam failure for my-workflows · Issue #1597 · dockstore ...

This seems to kill https://staging.dockstore.org/api/users/3/workflows from the client side (I see a 499 on the webservice) and then you can't see your own ......

Michael Franklin, Richard Lupat - Janis!

mem's documentation, there is one output called out with type Sam. ... janis translate myworkflow.py [cwl|wdl] --output-dir ...

Rhino 8 Development - Serengeti (Rhino WIP) - McNeel Forum

Some fun with those Revit error messages from hell: ... But many people would rather pick a higher tolerance in order to keep...

System Administration - Sybase Infocenter

more fault tolerant. ... Failure to specify the correct application ID would result in failure when the client tries to ... The Sybase...

Michael Franklin, Richard Lupat - Read the Docs

an uncompressed SAM file (the de facto standard for short read ... by finding the adapter or primer sequences in an error-tolerant way....