Use #ember-testing-container as a context when testing

Hi,

when updating to Ember 2.17 our tests start failing due to invalid didEnterViewport events - component with InViewport mixin was in window viewport, but was outside the #ember-testing-container viewport.

It seems that InViewport mixin should use #ember-testing-container when testing as a context instead of window here

• https://github.com/DockYard/ember-in-viewport/blob/master/addon/mixins/in-viewport.js#L67,
• https://github.com/DockYard/ember-in-viewport/blob/master/addon/mixins/in-viewport.js#L69,
• https://github.com/DockYard/ember-in-viewport/blob/master/addon/mixins/in-viewport.js#L225.

isInViewport detection should be also changed accordingly

• https://github.com/DockYard/ember-in-viewport/blob/master/addon/mixins/in-viewport.js#L98.

Happy to work on this if this makes sense.

Thanks

[rwjblue]

Awesome, thank you for confirming @bobisjan, and I’m sorry for that specific bug 😦

We’ll try to get 2.17.2 out soon to hopefully prevent others from hitting it…

[bobisjan]

Thanks @rwjblue,

with ember-cli@2.17.1 and changes from ember-cli/ember-cli#7507 our tests pass ✅ with ember-in-viewmport@2.1.1 (current) and also with @snewcomer’s interesection-observer branch 🎊.

So, I think that this issue can be closed ☺️.