Make TradeOffer class exportable
See original GitHub issueI’ve recently stumbled upon the Bluebird library and its’ Promise.promisifyAll method.
It would be cool to have the ability to run
Promise.promisifyAll(require('path-to-trade-offer-manager-class.js'))
Promise.promisifyAll(require('path-to-trade-offer-class.js'))
(or something like that, I didn’t try it yet)
I know I can require('steam-tradeoffer-manager/lib/index.js')
to get the TradeOfferManager
class, but if I’ll do require('steam-tradeoffer-manager/lib/classes/TradeOffer.js')
, it will return an empty object, since this file doesn’t export anything.
So it would be nice to make lib/classes/TradeOffer.js
export the TradeOffer
function, so I can require
just this class and do stuff with it.
Issue Analytics
- State:
- Created 6 years ago
- Comments:23 (13 by maintainers)
Top Results From Across the Web
Deriving the Offer Curve - Clark
As we noted in class, if the price ratio is "low enough", the country will actually import manufactured goods and export agricultural goods....
Read more >Tropico 5 General Discussions - Trade deals
Of course they offer a good price for exports/imports compared to automated trading for island surplus good. You can click on the ships...
Read more >Step-by-Step Guide to Exporting - Trade Commissioner Service
The Step-by-Step Guide to Exporting will help you get your business export-ready and well positioned for commercial success abroad.
Read more >Export Solutions - International Trade Administration
Export Solutions provides practical advice and business tools to help U.S. companies expand in global markets.
Read more >Release Notes - CSGO Trader
Release notes are meant to explain how to use new features and why certain design or policy decisions were made.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@autaut03 We’re happy you want to become a part of this open source project and already came with the list of things that are bad/broken in the library. Can’t wait to see more of your contributions. Please make sure you follow the contribution guide while submiting your PR. Here’s a nodejs maintenance chart that may be useful to check which node versions are not depreciated, thus should be supported, please keep them in mind.
I see you have a problem with adding items to trade, filtered by other things than
assetid
, here is a little snippet you may be interested to use:Also, I’ll just leave this, this and perhaps this here for you.
@autaut03:
@serge1peshcoff I would kind of rather just add promise support manually than use Bluebird, which seems like more of a hack to me. I haven’t reviewed your pull request yet, but I will check it later today. If you’ve done it in a good way then I may be willing to accept it instead of preferring to add promise support manually.