Reconnection after explicit disconnection

Hi Currently, the lib tries to reconnect after explicit disconnection from the server with “io server disconnect”. According to the socket.io protocol, the lib should not start reconnection for “io server disconnect” and “io client disconnect” reasons. Even setting up Options.Reconnection to false in OnDisconnected event handler doesn`t help, because library starts reconnection before I have received and handled this event.

[jlareo]

There are a lot of changes, I would wait a little bit until the tests are finished and we can guarantee that is stable enough

[doghappy]

io server disconnect
io client disconnect

In the first two cases (explicit disconnection), the client will not try to reconnect and you need to manually call socket.connect().

I have fixed it. https://github.com/doghappy/socket.io-client-csharp/commit/08f458776a11c286ec645d29db9a2dbdb2c60c2f

---

But in any case we need to have a guarantee of events processing order: OnDisconnected => OnBeforeReconnect => OnReconnecting.

In this commit, I asserted the sequence of events.

When an event occurs, I add the event name to the array, and finally assert their order.

---

I modified the logic of connection and reconnection, so there is no need to add the OnDisconnectedInternal event.

---

I personally don’t like the idea of modifying the options object inside the Disconnected event.

me to 😃 , to do this, from a programming point of view, we only need to do this:

    public class ReconnectArgs
    {
        public ReconnectedArgs()
        {
            AutoReconnection = true;
        }

        public int Attempts { get; }
        public bool AutoReconnection { get; set; }
    }

...

// public event EventHandler<int> OnReconnectAttempt;
public event EventHandler<ReconnectArgs> OnReconnectAttempt;

...
var args = new ReconnectArgs();
args.Attempts = Attempts;
//OnReconnectAttempt?.Invoke(this, Attempts);
OnReconnectAttempt?.Invoke(this, args);
if (!args.AutoReconnection)
    // to do

...

// subscriber
        private void SocketIO_OnReconnectAttempt(object sender, ReconnectArgs e)
        {
            if (condition)
            {
                e.AutoReconnection = false;
            }
        }

---

help subscribers to tune own business logic correctly and cancel reconnection flow if it’s required

In this scenario, can the problem be solved by calling “Dispose()”?