Some thoughts regarding KeyboardShortcut component

🐛 Bug report

Current behavior

KeyboardShortcut component seems to make multiple assumptions that seem specific to usage in our codebases, to web, to English locale, and more. In particular, it remaps CMD to CTRL on platforms other than macOS.

The problem is that this is not enough to meet platform conventions. On macOS, SHIFT should be first, and only replacing characters without reordering them does not result in display following platform guidelines. CMD + SHIFT + 1 renders as Ctrl Shift 1 on Windows and ⌘ ⇧ 1 on macOS, but it should be ⇧ ⌘ 1 on macOS.

Other potential issues:

• are we 100% sure that keys are always named “Ctrl” and “Shift” in other locales? I know that some e.g. German locales used “Strg” instead of “Ctrl”

Possible solutions

The component could only do rendering, and leave all other decisions to the caller.

[proxi]

it probably should support apps specifying different shortcuts for different platforms Not sure how complex this can get without making the calls to this component not too complex.

I don’t think this is the way to go. Shortcuts could just as well be dynamic (configurable by the user), could change by browser (to avoid clashes) etc. I think it’s much easier to replace shortcuts on client level (e.g. the way we do here by replacing the whole keymap or tweaking some of the constants).

[codedebugrepeat]

@proxi I can’t find a similar guideline on the order for Windows, but e.g. look at some official shortcuts here: https://support.microsoft.com/en-us/windows/keyboard-shortcuts-in-windows-dcc61a57-8ff0-cffe-9796-cb9706c75eec

A common pattern is for Shift to come second: Ctrl + Shift Alt + Shift

In general, most shortcuts only use 2 modifiers Windows + Alt Windows + Shift Ctrl + Alt etc.

although sometimes, three appear too

Windows logo key  + Ctrl + Shift + B | Wake PC from blank or black screen

Windows key always goes first. So, my not very scientific deduction of order would be, more or less (it’s somewhat flexible):

Windows, Ctrl, Alt, Shift