question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

test for dokku hostname failing

See original GitHub issue

For whatever reason, the test checking that the dokku hostname is set correctly started failing on master: https://travis-ci.org/github/dokku/ansible-dokku/jobs/709225176#L1266

I would like to point out that the tests on both the PR adding the test, and the following PR updating the dokku versions were passing: image

Is it the version bump that resurfaced the bug?

@josegonzalez As I mentioned before, I think it would be very useful to add a branch protection rule for the master branch that requires PRs to be “up to date” (I don’t have permissions to do this).

This should avoid such nasty surprises in the future.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:14 (14 by maintainers)

github_iconTop GitHub Comments

1reaction
josegonzalezcommented, Jul 17, 2020

I setup moderation for the repo meow.

0reactions
josegonzalezcommented, Sep 14, 2020

Oh heh yeah forgot about that.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Troubleshooting - Dokku Documentation
This could be a result of a bad proxy configuration ( http:5000:5000 may be incorrect). Run dokku proxy:report myapp to check if your...
Read more >
Deploying an Application - Dokku Documentation
This walkthrough uses the hostname dokku.me in commands. When deploying to your own server, you should substitute the domain dokku.me for the domain...
Read more >
Zero Downtime Deploy Checks - Dokku Documentation
To check an application that supports multiple hostnames, use relative URLs ... If the checks fail 5 times, the deployment is considered failed...
Read more >
Domain Configuration - Dokku Documentation
If an FQDN such as dokku.org is used as the application name, the global virtualhost will be ignored and the resulting vhost URL...
Read more >
Nginx Configuration - Dokku Documentation
should be escaped with a single backslash or can cause deploy failures. ... If the nginx-hostname has no output, the normal hostname algorithm...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found