Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Wildcard domains always get added

See original GitHub issue

Using dokku_domains a wildcard domain will always get added anew leading to multiple registrations of the same wildcard domain.

I would supply a PR but I’m not the well versed in neither Python nor Ansible, sorry.

Issue Analytics

State:
Created 4 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

mikkercommented, Oct 4, 2020

Seems like it’s no longer an issue.

0reactions

ltalirzcommented, Oct 3, 2020

@mikker Is this still an issue with the latest version of the role?

I just had a look and at least via the dokku interface (which I thought would be used under the hood by this role) this seems to be caught:

ubuntu@dokku:~$ dokku domains:add inflector3 '*.abc.de'
-----> Added *.abc.de to inflector3
-----> Configuring *.abc.de...(using built-in template)
-----> Configuring inflector3.materialscloud.io...(using built-in template)
-----> Creating https nginx.conf
       Enabling HSTS
       Reloading nginx
ubuntu@dokku:~$ dokku domains:add inflector3 '*.abc.de'
-----> Skipping: *.abc.de already added to inflector3
-----> Configuring *.abc.de...(using built-in template)
-----> Configuring inflector3.materialscloud.io...(using built-in template)
-----> Creating https nginx.conf
       Enabling HSTS
       Reloading nginx
ubuntu@dokku:~$ dokku domains:report inflector3
=====> inflector3 domains information
       Domains app enabled:           true
       Domains app vhosts:            inflector3.materialscloud.io *.abc.de
       Domains global enabled:        true
       Domains global vhosts:         materialscloud.io