Property names doesn't use Json [PropertyName] values with [FromQuery]

When using Model as parameter for controller Actions with [FromQuery] attribute - parameter names in Swagger UI shown as model property names.

public class QueryModelRenameToJsonPropertyNameFilter : IOperationFilter
{
   public void Apply(Operation operation, OperationFilterContext context)
   {
      foreach (var param in context.ApiDescription.ParameterDescriptions.Where(d => d.Source.Id == "Query"))
      {
         var toRename = ((DefaultModelMetadata)param.ModelMetadata)
            .Attributes.PropertyAttributes?.Any(x => x is JsonPropertyAttribute);

         if (toRename == true)
         {
            var opParam = operation.Parameters.SingleOrDefault(p => p.Name == param.Name);
            if (opParam != null)
            {
               JsonPropertyAttribute attr = (JsonPropertyAttribute)((DefaultModelMetadata) param.ModelMetadata)
                  .Attributes.PropertyAttributes.First(x => x is JsonPropertyAttribute);

               opParam.Name = attr.PropertyName;
            }
         }
      };
   }
}

If someone need this feel free to use

[domaindrivendev]

The issue title (and your filter implementation) seems to indicate that you’re expecting Swashbuckle to honor JsonPropertyAttributes for properties that are bound to query parameters. I’m just making the point that JsonPropertyAttributes don’t have any meaning in this context, independently of Swashbuckle, and therefore I don’t believe Swashbuckle should honor them in this way.

If you’re using the same model for both query parameters and JSON bodies then I can see how your filter affords some convenience. However, to keep your query string serialization decoupled from JSON serialization, you could also do the following:

public class PagingParameters
{
   [FromQuery(Name = "pn")]
   [JsonProperty(Name = "pageNo")]
    public int PageNo { get; set; }

   [FromQuery(Name = "ps")]
   [JsonProperty(Name = "pageNo")]
    public int PageSize { get; set; }
}

Swashbuckle wil honor this setup without the need for an operation filter.

[CaCTuCaTu4ECKuu]

And also. As you mention that I expect lib to honor JsonPropertyAttributes. I expect that because the lib do it in all other cases except FromQuery, so why shouldn’t I, and others, expect it in that particular case.