StackOverflow when using SchemaRegistry.GetOrRegister in ISchemaFiler.Apply

Hi,

I’ve got a StackOverflow while using a ISchemaFilter that need to register a new type. The recursion happens because I’m applying the filter to a referenced type, not a top-level type. During the while loop of GetOrRegister, my filter get’s called for type A in which I call GetOrRegister for type B. This loops again on the ‘not-yet-compiled’ types and A it’s still there … and calls again my filter on the A type.

You can reproduce with an endpoint that takes this type as ([FromBody]Command c) signature.

public class Command 
{
    public int A {get ;set; }
    public Data Data {get;set;}
}

public class Data
{
    public int A {get;set;}
    public int B {get;set;}
    public IDictionary<object, object> ComplexFieldForWhichIWantToBuildSchema {get;set;}
}

public Filter : ISchemaFilter
{
    public void Apply(Schema schema, SchemaRegistry schemaRegistry, Type type)
    {
        if (type == typeof(Data))
        {
            var t = typeof(KeyValuePair<string, string>[]);
            schema.properties["ComplexFieldForWhichIWantToBuildSchema"] = schemaRegistry.GetOrRegister(t);
        }
    }
}

[ghost]

I’m still seeing this issue in release 5.5.3. In my case I’m attempting to register a previously unregistered type, which might be different from the scenario in the test added in #890. Looks like it is attempting to re-run the SchemaFilters on the same type over & over which is causing the stack overflow exception.

[domaindrivendev]

See PR #890 which resolves this. Will be available with the upcoming v5.5.0 release