try/catch (in some cases) causes resolveCallIds to fail

Reproduction

• run express#20 (“should throw when Content-Type is an array”)
  • you see several errors coming from RuntimeDataProvider.resolveCallIds
    • NOTE: this tries to look up the callId (traceId) of any CallExpression that was recorded while running; based on staticTrace data
  • the issue seems to come from the fact that an error is thrown inside the try block in lib\router\layer.js:95
• express#18 shows similar symptoms.

NOTE: For some reason samples/error1.js does not suffer from that problem.

• -> Maybe it only happens from nested function calls inside the try block? Not sure…

Steps to take

• Talk to @MiccWan (he is already researching this problem)
• First, find out if the instrumentation data is complete: i.e. every call-related trace must have a callId and the call result trace must have a resultCallId.
  • -> Maybe add a Verbose mode that monitors the call stack resolution algorithm (similar to how Verbose mode in traceVisitors monitors the AST exploration)
• There seems to be a bug where ThrowArgument has two result traces (but only one BCE). This might or might not be related (but also needs fixing).
  • At least this is what happens in Express#8.
  • Need to isolate and fix this in instrumentation.
  • NOTE: Traced in #346

[MiccWan]

#346 mentioned that ThrowArgument is traced more than once.

[Domiii]

Express#20 has long been fixed, and, while still dirty, resolveCallIds has been revised and its internal error reporting largely improved several times since. Also, @MiccWan has done a great job, fixing up mentioned RDP and PDP issues.