Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"Maximum update depth exceeded" when clicking the image

See original GitHub issue

I have been getting this error and it looks like it was introduced recently. At first I assumed it was an issue in my local setup, but I can reproduce it in the demo.

It seems to come from the fact that the onChange gets called in an infinite loop.

Version: 6.0.7
Steps to reproduce:
1. open demo (Tried in Firefox and Chrome)
2. upload an image
3. click anywhere in the image
4. notice React Error
Error:

Invariant Violation Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.

Note: rolling back to v6.0.5 fixes it.

Issue Analytics

State:
Created 5 years ago
Comments:12 (7 by maintainers)

Top GitHub Comments

2reactions

DominicTobiascommented, Jan 23, 2019

@noashka Please try 6.0.12 this issue should be fixed now. It was proving too problematic to try and fix/complete invalid aspect crops every component update/render, so I just fix/complete them if they are incorrect on image load

0reactions

DominicTobiascommented, Jan 24, 2019

Great thanks for checking

On Thu, 24 Jan 2019 at 11:03, Vadim notifications@github.com wrote:

@DominicTobias https://github.com/DominicTobias You’ve fixed it! Thank you for help!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DominicTobias/react-image-crop/issues/218#issuecomment-457157757, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuZ-poQ31IvaJQwT0aLGBYIgWHtrsSgks5vGZMfgaJpZM4YeCHZ .