The return of "Error: Maximum update depth exceeded."

Perhaps related to #218

When using percentageCrop and adjusting the crop selection in certain circumstances this error is thrown:

Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.

I have created a variant of your hooks demo in which you can usually replicate this bug.

Reproduction Steps (Updated.

1. Go to https://codesandbox.io/s/strange-lalande-91wgp
2. Click “Set bad crop data” in rendered view
3. Error: Maximum update depth exceeded should be thrown

Example of reproduction:

If I get a spare moment, I’ll see if I can help debug further for you!

Edit: I’ve updated the example with buggy crop data that should trigger an infinite loop on update.

[DominicTobias-b1]

Hey thanks I was worried about this since I added “completing aspect crops” on componentDidUpdate. The idea was the make it easier to make a percentage aspect crop without having to do some maths yourself.

// isAspectCropInvalid https://github.com/DominicTobias/react-image-crop/blob/master/lib/ReactCrop.js#L126

// componentDidUpdate https://github.com/DominicTobias/react-image-crop/blob/master/lib/ReactCrop.js#L285

The problem is probably that the library thinks that the aspect crop is invalid over and over again and keeps trying to correct it due to imprecision when converting percentage to pixels. What browser and version is that by the way?

I will take a look in the next day or 2

[DominicTobias]

Thanks @jamsinclair for the clear reproducible scenario, please try 8.6.2