v8.6.10 broke our build, rolling back to 8.6.9 resolved issue
See original GitHub issueI didn’t yet look into what exactly is wrong with recent changes, but locally on windows it caused no issues, but on our Linux based CI build, the recent changes (8.6.10) caused the following error:
` ERROR in ./node_modules/react-image-crop/lib/ReactCrop.scss 20:57:47 Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js): 20:57:47 ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js): 20:57:47 SassError: Invalid CSS after “…le-height: math”: expected expression (e.g. 1px, bold), was “.div($drag-handle-h” 20:57:47 on line 21 of node_modules/react-image-crop/lib/ReactCrop.scss 20:57:47
$half-drag-handle-height: math.div($drag-handle-height, 2); 20:57:47
20:57:47 ------------------------------^ 20:57:47
20:57:47 at C:\BuildAgent\work\b859c7b6b98da306\node_modules\webpack\lib\NormalModule.js:316:20 20:57:47 at C:\BuildAgent\work\b859c7b6b98da306\node_modules\loader-runner\lib\LoaderRunner.js:367:11 20:57:47 at C:\BuildAgent\work\b859c7b6b98da306\node_modules\loader-runner\lib\LoaderRunner.js:233:18 20:57:47 at context.callback (C:\BuildAgent\work\b859c7b6b98da306\node_modules\loader-runner\lib\LoaderRunner.js:111:13) 20:57:47 at Object.callback (C:\BuildAgent\work\b859c7b6b98da306\node_modules\sass-loader\dist\index.js:62:7) 20:57:47 at Object.done [as callback] (C:\BuildAgent\work\b859c7b6b98da306\node_modules\neo-async\async.js:8069:18) 20:57:47 at options.error (C:\BuildAgent\work\b859c7b6b98da306\node_modules\node-sass\lib\index.js:293:32) 20:57:47 @ ./src/modules/common/components/file-upload-dialog/image-cropper/image-cropper.tsx 11:0-45 20:57:47 @ ./src/modules/common/components/file-upload-dialog/file-upload-dialog.tsx 20:57:47 @ ./src/modules/settings/profile-settings/components/profile-avatar/profile-avatar.tsx 20:57:47 @ ./src/modules/settings/profile-settings/components/profile-settings-list/profile-settings-list.tsx 20:57:47 @ ./src/modules/settings/profile-settings/profile-settings.tsx 20:57:47 @ ./src/modules/settings/settings.tsx 20:57:47 @ ./src/router/routes.tsx 20:57:47 @ ./src/app.tsx 20:57:47 @ ./src/index.tsx 20:57:47 @ multi ./src/index `
Issue Analytics
- State:
- Created 2 years ago
- Reactions:5
- Comments:9 (1 by maintainers)
Top GitHub Comments
Like Tobias already pointed out, you can always fix it to 8.6.9 in your package.json
"react-image-crop": "8.6.9",
Notice the ^ or ~ are missing (important)
We’re unfortunately using node-sass, which I guess is the issue. Its a good hint, we should plan to move away from node-sass but we’re in end-game and I’m not sure of the impact of switching right now. We will look into this.