Dictionary passed into machine class is not used on slack client

Issue

Passing settings into the Machine class is ignored when generating the SlackClient. The Slack client class just runs a local_settings import via import_settings() when this seems to be unnecessary.

from machine import Machine
from machine.utils.collections import CaseInsensitiveDict

base_settings = {
    'PLUGINS': [],
    'STORAGE_BACKEND': 'machine.storage.backends.memory.MemoryStorage',
    'DISABLE_HTTP': True,
    'HTTP_SERVER_HOST': '0.0.0.0',
    'HTTP_SERVER_PORT': 8080,
    'HTTP_SERVER_BACKEND': 'wsgiref',
    'HTTP_PROXY': None,
    'HTTPS_PROXY': None,
    'KEEP_ALIVE': None,
    'SLACK_API_TOKEN': '<redacted token>'
}

settings = CaseInsensitiveDict(base_settings)
bot = Machine(settings=settings)
bot.run()

output:

pipenv run python test-bot.py                                     
Loading .env environment variables…
Initializing Slack Machine:
    Loading settings...
Traceback (most recent call last):
  File "test-bot.py", line 18, in <module>
    bot = Machine(settings=settings)
  File "/Users/henry.hollenstain/.virtualenvs/bot-9dQm3zAV/lib/python3.7/site-packages/machine/core.py", line 59, in __init__
    self._client = LowLevelSlackClient()
  File "/Users/henry.hollenstain/.virtualenvs/bot-9dQm3zAV/lib/python3.7/site-packages/machine/utils/__init__.py", line 14, in __call__
    cls._instances[cls] = super(Singleton, cls).__call__(*args, **kwargs)
  File "/Users/henry.hollenstain/.virtualenvs/bot-9dQm3zAV/lib/python3.7/site-packages/machine/clients/singletons/slack.py", line 33, in __init__
    self.rtm_client = RTMClient(token=slack_api_token, proxy=http_proxy)
  File "/Users/henry.hollenstain/.virtualenvs/bot-9dQm3zAV/lib/python3.7/site-packages/slack/rtm/client.py", line 118, in __init__
    self.token = token.strip()
AttributeError: 'NoneType' object has no attribute 'strip'

Placing a local_settings.py file with a token works.

SLACK_API_TOKEN = 'redacted' 

pipenv run python test-bot.py                                           
Loading .env environment variables…
Initializing Slack Machine:
    Loading settings...
    Initializing storage using backend: machine.storage.backends.memory.MemoryStorage
    Loading plugins...

Starting Slack Machine:
    ✓ Connected to Slack
    ✓ Scheduler started
    ✓ Dispatcher started

It seems when generating the slack client https://github.com/DandyDev/slack-machine/blob/master/machine/core.py#L59

The client re imports settings already on the Machine class instead of passing in the settings to the LowLevelSlackClient: https://github.com/DandyDev/slack-machine/blob/master/machine/clients/singletons/slack.py#L30

Proposed solution

Pass settings from the Machine class into LowLevelSlackClient

[DonDebonair]

Only after I wrote my reply, I actually saw your PR. With some adjustments it actually might work. I will have a look at your PR in the coming days, so don’t close it yet.

[hhollenstain]

@DandyDev That is a great idea. I forgot you are checking for SM_ . Able to patch the os.environ dict with os.environ['SM_SLACK_API_TOKEN'] = slack_token and worked perfectly.