can-dynamic-import tag breaks auto-reload in the modlet
See original GitHub issueHow often can you reproduce it?
- Always
- Sometimes
- Rarely
- Unable
- I didn’t try
Description:
Using <can-dynamic-import>
to import a modlet effectively disables the build from watching files in the imported modlet for changes.
Steps to reproduce:
In index.stache
we use <can-dynamic-import>
to import a myapp/components/footer/ modlet:
<can-dynamic-import from="myapp/components/footer/" isResolved:to="*footerTagReady"></can-dynamic-import>
{{#if *footerTagReady}}
<my-footer app:from="this"></my-footer>
{{/if}}
- If changes are made to
index.stache
, the console rebuilds it automatically: - Start from:
- Make an edit:
- Notice the console reloads the index.stache, and the website reflects the change:
Reloading myapp@2.0.0#_app/index.stache!done-autorender@1.3.2#no-zone
-
If changes are made to any file in
myapp/components/footer/
, such asfooter.js
orfooter.stache
, new changes are not rebuilt. There is no new console output and the webpage is not updated. -
Start with the following in
myapp/components/footer/footer.stache
- Make a change, notice that the console does not rebuild the footer component:
- The website is also not rebuilt and no changes are seen:
- The changes are only seen after a manual refresh of the browser window.
- The Console still has not visibly indicated that it has rebuilt the component.
Received client connection
Expected results:
Using donejs develop
in this case, changes to any file in the myapp/components/footer/ directory should be automatically picked up and rebuilt by the console.
Actual results:
Using donejs develop
in this case, changes to any file in the myapp/components/footer/ directory are no longer automatically picked up and rebuilt by the console.
Environment:
Software | Version |
---|---|
donejs -V | 1.0.1 |
node -v | 6.11.3 |
npm -v | 5.4.2 |
Browser | Any |
Operating system | Windows 10 |
Issue Analytics
- State:
- Created 6 years ago
- Comments:8 (6 by maintainers)
Top GitHub Comments
Fantastic! You guys rule, as usual. Thanks so much!
This was released in steal 1.5.17