react-query plugin with graphql-request fetcher generates invalid infinite query if query has no arguments

Describe the bug

The latest version introduces an issue where, if an infinite query has no arguments, the react-query plugin generates invalid types.

Your Example Website or App

/

Steps to Reproduce the Bug or Issue

1. write a query without arguments
2. observe type error in generated code

The error comes from the 3rd argument passed to fetcher:

error TS2345: Argument of type '{ [x: string]: any; }' is not assignable to parameter of type 'Exact<{ [key: string]: never; }>'.
  'string' index signatures are incompatible.
    Type 'any' is not assignable to type 'never'.

Expected behavior

No error.

Screenshots or Videos

No response

Platform

• OS: macOS
• NodeJS: 16.7.1
• graphql version: 16.6.0

    "@graphql-codegen/cli": "^2.13.7",
    "@graphql-codegen/typescript": "^2.8.0",
    "@graphql-codegen/typescript-graphql-request": "^4.5.7",
    "@graphql-codegen/typescript-operations": "^2.5.5",
    "@graphql-codegen/typescript-react-query": "^4.0.3",

Codegen Config File

scalars omitted to keep it short

overwrite: true
generates:
  src/modules/common/generated/client.graphql.ts:
    documents: "src/**/*.graphql"
    plugins:
      - "typescript"
      - "typescript-operations"
      - "typescript-react-query"
    config:
      dedupeFragments: true
      immutableTypes: true
      skipTypename: true
      maybeValue: T | null | undefined
      namingConvention:
        enumValues: keep
        typeNames: keep
      strictScalars: true
      fetcher: graphql-request
      exposeQueryKeys: true
      addInfiniteQuery: true

Additional context

Only happens in latest version.

[EandrewJones]

Sorry for the delay on this folks. I promise I’m going to spend time on the fix tomorrow.

I doubt it’ll involve adding a new parameter to the config file to specify which queries have infiniteQuery generated for them (though that type of fine grained control would be cool). I think some simple type checking and conditional statements will suffice.

On Sat, Nov 19, 2022, 1:55 AM Wiley McKay Conte @.***> wrote:

How can you set config like addInfiniteQuery: false for a specific subset of .graphql files?

— Reply to this email directly, view it on GitHub https://github.com/dotansimha/graphql-code-generator/issues/8517#issuecomment-1320819085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2T6ANPFNQWZ6WS264JH4LWJB2VHANCNFSM6AAAAAARM2FP6A . You are receiving this because you commented.Message ID: @.***>

[wileymc]

How can you set config like addInfiniteQuery: false for a specific subset of .graphql files?