Suggestion: Use Pick<T, K> to generate query types

Is your feature request related to a problem? Please describe. Currently, we just have a copy of original type for a query

Describe the solution you’d like I think a more clear approach would be to use Pick<T, K> operator to make a connection to the original type.

So this would be like this

export interface TypeA {
  id: string;
  name: string;
  age: number;
}

export namespace MyQuery {
  export type TypeA = Pick<TypeA, 'id' | 'name'>
}

See it’s in action here https://medium.com/@curtistatewilkinson/typescript-2-1-and-the-power-of-pick-ff433f1e6fb

[itscarlosrufo]

Plugin typescript-client

I’ve been taking a look to this feature proposal, the idea of using Pick it’s quite interesting as y’all have mentioned before. I’d love to discuss what would be the best way implement this, as I have no much idea about the library, I’d really appreciate your opinion & hopefully guidance. I’ve noticed that the typescript-client is the responsible for generating the types that’d change, refactoring its handlebar template it’d probably work but yep, surely I’m missing a lot of corner cases.

Check this example out and let’s discuss how we could solve it, the proposal is tested & working with typescript-react-apollo with no changes in its template.

Query

query allRockets {
  rockets {
    id
    name
    first_stage {
      reusable
      engines
    }
  }
}

Current Types

export type AllRocketsVariables = {};

export type AllRocketsQuery = {
  __typename?: 'Query';
  rockets: Maybe<AllRocketsRockets[]>;
};

export type AllRocketsRockets = {
  __typename?: 'Rocket';
  id: Maybe<string>;
  name: Maybe<string>;
  first_stage: Maybe<AllRocketsFirstStage>;
};

export type AllRocketsFirstStage = {
  __typename?: 'RocketFirstStage';
  reusable: Maybe<boolean>;
  engines: Maybe<number>;
};

Proposal Iterate over the fields until all of them are primitive types (didn’t code it yet but I guess this is possible), it’d require to include the typescript-server in order to generate & pick the interfaces! Probably the Pick types have to include Maybe types too.

export type AllRocketsVariables = {};

export type AllRocketsQuery = {
  __typename?: 'Query';

  rockets: Maybe<AllRocketsRockets[]>;
};

export type AllRocketsRockets = Pick<Rocket, 'id' | 'name' | 'first_stage'> & {
  first_stage: Pick<RocketFirstStage, 'reusable' | 'engines'>;
};

cc/ @dotansimha @ardatan

Help wanted hahah 🙏🏻

[esamattis]

Will do