Support TypeScript 4.3 noImplicitOverride in typescript-apollo-angular

Typescript 4.3 introduced a new override keyword and the noImplicitOverride rule.

It would be nice to support this keyword with a new option, as the typescript-apollo-angular plugin generates subclasses of Apollo’s Mutation classes and overrides Mutation.document, for example:

export class AuthResetPasswordUserUpdatePasswordGQL extends Apollo.Mutation<AuthResetPasswordUserUpdatePasswordMutation, AuthResetPasswordUserUpdatePasswordMutationVariables> {
  document = AuthResetPasswordUserUpdatePasswordDocument;
  // ...
}

As I use noImplicitOverride in my project, unfortunately the generated code breaks the compilation with this kind of errors:

Error: apps/client/client.gen.graphql.ts:771:5 - error TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Mutation<AuthLoginLoginWithPasswordMutation, Exact<{ email: string; password: string; }>>'.

771     document = AuthLoginLoginWithPasswordDocument;
        ~~~~~~~~

Correct code output with this rule would be:

export class AuthResetPasswordUserUpdatePasswordGQL extends Apollo.Mutation<AuthResetPasswordUserUpdatePasswordMutation, AuthResetPasswordUserUpdatePasswordMutationVariables> {
  override document = AuthResetPasswordUserUpdatePasswordDocument;
  // ...
}

[ardatan]

This would be breaking change if we make it by default. It would be better to have it with a configuration flag. We’d love to accept PRs for this change.

[toverux]

Well since it’s been solved I’m closing my issue!