return http server from .start

Hi,

I’m running some unit tests with yoga and I’d like to close the server programatically but the http server isn’t accessible, and express doesn’t offer .close(). Would you be open to a pr that adds the httpServer as a property? or is there a better way to achieve this result?

[DavidBabel]

Is there any other way to get the http instance thant start ? Because for my tests with supertest i don’t want to start my server explicitly.

[craigmulligan]

@JorgeCeja,

The http instance is returned from the server.start() method and not the server constructor. So check that you are invoking the method on the http instance and not the graphql server instance.

const server = new GraphQLServer({ typeDefs, resolvers })
server.start()
server.close() // wont work

const server = new GraphQLServer({ typeDefs, resolvers })
const httpServer = server.start()
httpServer.close() // will work