onDisconnected called multiple times for a disconnected device

I noticed some behavior that seems strange with the onDisconnected listener. If a device is connected and then disconnected, the listener is called once, as it should. But if the same device connects and disconnects again in a short period, the listener is called twice. Then on the next disconnect three times and so on. This is on Android with ble-plx 0.8.0.

My simplified code is something like this:

    bleManagerPlx.startDeviceScan([SERVICE], { allowDuplicates: false }, (error, device) => {
      if (device.name.startsWith('......')) {
        if ('a check that the device is not already connected') {
          connectDevice(device.id);
        }
      }
    })


  bleManagerPlx.connectToDevice(deviceId)
    .then((device) => {
      device.onDisconnected((error, disconnectedDevice) => {
        console.log('Disconnected ', disconnectedDevice.name);
      });
    });

Now, I could store the subscription that is returned by onDisconnected() and call remove on it to stop listening, but I think that the subscription should have been removed by the manager when the connection is cancelled. Is that by design?

Thanks.

[vldgeorgiev]

@dariuszseweryn Well, yes, I register a new listener once a device is connected. I think it doesn’t matter if it is a new device, or a reconnect of an old one after a minute, an hour or a day. At least to me it seems better to automatically unsubscribe from the old listener once a device disconnects. This device may never reconnect, so why should the listener stay active.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.