Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Arcade allows build to pass as green even when target shows error and build output is corrupted

See original GitHub issue

In this build I get the following error:

##[error].packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19521.4\tools\VisualStudio.InsertionManifests.targets(23,5): error : Property VisualStudioDropName must be specified in official build that produces Visual Studio insertion components.

Yet the build passes. This will cause the build output to be invalid and should fail the build

Issue Analytics

State:
Created 4 years ago
Comments:11 (11 by maintainers)

Top GitHub Comments

1reaction

tmatcommented, Oct 23, 2019

I get the interpretation, but I think the current behavior is incorrect and inconsistent with a common sense rule “if a task runs and it fails the build should fail”. I’d be fine if msbuild chose not to run these AfterTargets at all. But running them and ignoring their failure is imo wrong.

Nevertheless, I have been fixing these cases. I guess there are some more left.

1reaction

riarenascommented, Oct 23, 2019

Does look related. All our previous instances of something like this were in the powershell side, but that was not the case here. I’ll take a look at that issue. Thanks Davis.