question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUILD]Typo : InstallDotNet call twice GetDotNetInstallScript

See original GitHub issue

From @tebeco on Wednesday, July 17, 2019 1:19:05 PM

Describe the bug

At the end of the line, it seems that an manual indent or reformat ended up in a duplicate call to GetDotNetInstallScript :

Scroll to the right of this code block :

function InstallDotNet([string] $dotnetRoot, [string] $version, [string] $architecture = "", [string] $runtime = "", [bool] $skipNonVersionedFiles = $false) {  $installScript = GetDotNetInstallScript $dotnetRoot
  $installScript = GetDotNetInstallScript $dotnetRoot
  $installParameters = @{

Expected behavior

only one call should be made to GetDotNetInstallScript in InstallDotNet

Side notes

It’s like this from the very first commit, it looks like it was created by either an automation or from an already existing script, so this may be existing in another repo somewhere publicly or internaly https://github.com/aspnet/AspNetCore/commit/347ddcb6e20a5ef291972604407894baf5f14526#diff-58d6d2c2760628d9551cc8b40461ce53

Copied from original issue: aspnet/AspNetCore#12275

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
tebecocommented, Jul 17, 2019

done

0reactions
dougbucommented, Aug 30, 2019

The problem was a typo where $installScript = GetDotNetInstallScript $dotnetRoot appeared at the end of the first line @tebeco quoted in the description as well as on the second line. We should have closed this issue when @jonfortescue merged #3305.

Read more comments on GitHub >

github_iconTop Results From Across the Web

dotnet-install scripts - .NET CLI
The dotnet-install scripts perform a non-admin installation of the .NET SDK, which includes the .NET CLI and the shared runtime.
Read more >
Install .NET on Linux without using a package manager
Demonstrates how to install the .NET SDK and the .NET Runtime on Linux without a package manager. Use the install script or manually...
Read more >
What happens if a service is added twice? : r/dotnet
Using Add(IServiceCollection, ServiceDescriptor) is not idempotent and can add duplicate ServiceDescriptor instances if called twice. Using ...
Read more >
Generate .NET Assembly and Build .NET Application
Create a .NET assembly in MATLAB and integrate it with sample C# code.
Read more >
dotnet-install.sh not adding dotnet command on Ubuntu
first I install it using the command curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin for which I get the following result:.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found