Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Create-Directory in tools won't create directory if at least one exists

See original GitHub issue

Is this issue blocking (yes/no) no
Is this issue causing unreasonable pain (yes/no) no

Create-Directory in tools.ps1 won’t create non-existing directories when given at least one existing path. The reason is that it takes string array, but then does not iterate over it, which due to powershell casting rules will return $true, $false in Test-Path which casts to $true in if and skips the folder creation.

There is no need to check paths when creating foders on the FileSystem provider when using -Force. It wil only create folders that do not exist.

function Create-Directory([string[]] $path) {
  if (!(Test-Path $path)) {
    New-Item -path $path -force -itemType 'Directory' | Out-Null
  }
}

# Pester tests for repro
Describe 'Create-Directory broken' { 
    It 'returns false given at least one non-existing path' { 
        $existingPath = [IO.Path]::GetTempPath()
        $nonExistingPath = "TestDrive:/thisPathDoesNotExist" 

        [string[]] $path = $existingPath, $nonExistingPath
        [bool] $actual = Test-Path $path 

        $actual | Should -BeFalse
    }

    It 'creates folder given one existing path and one non existing path' { 
        $existingPath = [IO.Path]::GetTempPath()
        $nonExistingPath = "TestDrive:/thisPathDoesNotExist" 

        [string[]] $path = $existingPath, $nonExistingPath
        
        Create-Directory $path 

        $nonExistingPath | Should -Exist
    }
}

# fixed
function Create-Directory([string[]] $Path) {
    # no need to check path, New-Item will only create non-existing items on FileSystem provider
    New-Item -Path $path -Force -ItemType 'Directory' | Out-Null
}

Describe 'Create-Directory fixed' { 
    It 'creates folder given one existing path and one non existing path' { 
        $existingPath = [IO.Path]::GetTempPath()
        $nonExistingPath = "TestDrive:/thisPathDoesNotExist" 

        [string[]] $path = $existingPath, $nonExistingPath
        
        Create-Directory $path 

        $nonExistingPath | Should -Exist
    }
}

Describing Create-Directory broken
  [-] returns false given at least one non-existing path 21ms
    Expected $false, but got $true.
    15:         $actual | Should -BeFalse
  [-] creates folder given one existing path and one non existing path 47ms
    Expected path 'TestDrive:/thisPathDoesNotExist' to exist, but it did not exist.
    26:         $nonExistingPath | Should -Exist

Describing Create-Directory fixed
  [+] creates folder given one existing path and one non existing path 13ms