Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Documentation updates can only be merged by admins
See original GitHub issue- This issue is blocking
- This issue is causing unreasonable pain
There’s a required PR validation check on master that requires some checks to run that don’t actually trigger on doc changes. This means doc PRs are never green and can’t be merged by ordinary users. Without any guidance (clear pathway to get unblocked) this is a terrible experience and discourages doc updates.
Ideas:
- Fix the checks.
- Add guidance (or make it easier to find?) how to resolve this (e.g. who to ping to get it merged).
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
About protected branches
Require deployments to succeed before merging ... You can require that changes are successfully deployed to specific environments before a branch can be...
Read more >Merge request workflows | GitLab
Developers push feature branches to the project and create merge requests to have their feature branches reviewed and merged into one of the...
Read more >Merge request approval rules
Administrators can change the merge request approvals settings to prevent users from overriding approval rules for merge requests.
Read more >Checks for merging pull requests | Bitbucket Data Center ...
By default, merge check settings from the project level are inherited by the repositories. Repository admins can either set a merge check to ......
Read more >Set Up Branch and Merge Restrictions
Restrict who can merge changes into the branch. Enable Quality Gates to ensure that only successfully tested, reviewed and approved changes ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
I think we should turn them back on. This is the only repo where we have this workflow, and I don’t think it saves us much when it comes to machine savings. The merge still triggers a CI build and official build that are both giant no-ops too, so the burden on the PR author seems unwarranted.
I think we can get away with just enabling the builds back on. I like the idea of the CI short-circuit if we see that this is putting a lot of strain on the build machines.