Fix Race Condition between Queue Insights & AzDo Build Checks

• This issue is blocking
• This issue is causing unreasonable pain

QueueInsights needs to obtains the list of pipelines from a given PR. Currently, this is done by using GetBuildCheckRunsAsync from IGitHubChecksService which parses the checks from Github for a given PR. However, we manage to beat AzDo in fetching these checks before they posted them.

There are two solutions for this that I can see:

1. Add a new Controller in HelixAPI that listens to events from AzDo, and then post the queue insights check
2. Wait a certain amount of time or loop untill we get all the build checks.

What are your thoughts? @ulisesh @ChadNedzlek @AlitzelMendez @riarenas

[melotic]

Thanks for the feedback. Integrating this into build analysis is the way to go.

[ChadNedzlek]

It seems like just putting this functionality in build analysis is probably the route to go… we want to provide some insights into every check that’s running, about all the builds that are related to that PR… that’s exactly what build analysis is doing. Adding an extra “and also go generate the queue insights check too” method call in the AnalysisProcessor (which already has all the information needed and all the timing/retry stuff in place) seems reasonable to me? It doesn’t feel like this “isn’t build analysis” enough that it needs to be exiled to a different project, it just a slightly broader definition of analysis. 😃