question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

GetDotNetInstallScript has no retry behavior, fails on network flakiness

See original GitHub issue
  • Is this issue blocking (no)
  • Is this issue causing unreasonable pain (no)

Reported by @333fred : https://dev.azure.com/dnceng/public/_build/results?buildId=503683&view=logs&jobId=1d3b3092-ebea-54d1-0a97-42044640f186&j=1d3b3092-ebea-54d1-0a97-42044640f186&t=229ccf78-8103-517e-b52d-eda4bea77a29

https://github.com/dotnet/arcade/blob/master/eng/common/tools.ps1#L191

We need to add basic retry logic to this function:

function GetDotNetInstallScript([string] $dotnetRoot) {
  $installScript = Join-Path $dotnetRoot 'dotnet-install.ps1'
  if (!(Test-Path $installScript)) {
    Create-Directory $dotnetRoot
    $ProgressPreference = 'SilentlyContinue' # Don't display the console progress UI - it's a huge perf hit
    Invoke-WebRequest "https://dot.net/$dotnetInstallScriptVersion/dotnet-install.ps1" -OutFile $installScript
  }

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
MattGalcommented, Feb 5, 2020

Fairly certain I have seen this fail on linux; I believe the reason being curl’s version of retry is not for all possible error scenarios.

1reaction
MattGalcommented, Feb 4, 2020

@vzarytovskii - please consider Jared’s feedback when adding this: (" Is there any way to have curl dump diagnostic data too?")

Read more comments on GitHub >

github_iconTop Results From Across the Web

Doesn't work well on a flaky connection · Issue #746
I'm running a yarn upgrade command and got this message multiple times: warning There appears to be trouble with your network connection.
Read more >
Stop the Retries in Tests & Reruns of Failing Tests
Flaky tests happen because the test conditions fail to occur consistently. Why? Anand Bagmar helps you uncover the root causes of flakiness.
Read more >
Is retrying failed tests good strategy to handle flaky tests?
My strong advice: Do not use automated retries. Instead, find the uncontrolled ... Accommodating flaky tests through retries is dangerous.
Read more >
Playwright-Handling flaky tests-Retry blocks of the code- ...
Test retries are a way to automatically re-run a test when it fails. This is useful when a test is flaky and fails...
Read more >
Troubleshoot YouTube error messages - Android
There are many root causes of error messages. Many are out of YouTube's control, such as a bad Internet connection or insufficient memory...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found