Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve commit msg

See original GitHub issue

This issue is blocking
This issue is causing unreasonable pain

Improve commit message

Actual issue - dotnet/arcade#3328

The commit message for the dependency update PRs are really long. So in order to condense it, this is part one change for the issue which was initially created (#3328). Basically removing the redundancy in the commit message especially related to the from version and to version.

The second part of the issue which deals with the : Dependency update is from the same repo and the builds differ then just get the latest build number and discard the older ones. ( Eg : dotnet/arcade-validation@e788b97) will be worked on as part of #3328

Currently the commit message looks like this  :

Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200507.9
Microsoft.AspNetCore.Mvc.Razor.Extensions: 5.0.0-preview.5.20257.7 -> 5.0.0-preview.5.20257.9
Microsoft.AspNetCore.Razor.Language: 5.0.0-preview.5.20257.7 -> 5.0.0-preview.5.20257.9
Microsoft.CodeAnalysis.Razor: 5.0.0-preview.5.20257.7 -> 5.0.0-preview.5.20257.9
Microsoft.NET.Sdk.Razor: 5.0.0-preview.5.20257.7 -> 5.0.0-preview.5.20257.9

After this change

Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200507.9
Microsoft.AspNetCore.Mvc.Razor.Extensions , Microsoft.AspNetCore.Razor.Language , Microsoft.CodeAnalysis.Razor , Microsoft.NET.Sdk.Razor
From Version 5.0.0-preview.5.20257.7 -> To Version 5.0.0-preview.5.20257.9

Issue Analytics

State:
Created 3 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

riarenascommented, May 11, 2020

If you want to use a separate issue that’s fine, but it probably needs context / description of the actual issue you plan to fix than what is present here. I don’t think it makes sense to create a PR, and then retroactively create an issue just to track the PR flow.

The two checkboxes are there for us to be able to determine the priority of an issue. If you’re going to mark either checkbox, it should include an explanation of what is being blocked, or what exactly is the unreasonable pain that the issue is causing on the users.

Nowhere in this issue does it mention that the commit message is really long, and that we’ll be condensing the versions. You are just adding the description of your current PR to the issue.

0reactions

epananthcommented, May 11, 2020

Sure, I can add more context to this issue 😃

Top Results From Across the Web

How to Write a Good Git Commit Message | Git Best Practices

Writing a Good Git Commit Message ; Make changes; Stage changes; Commit changes ; Avoid unnecessary capitalization; Double check your spelling; Don't end...

Write Better Commits, Build Better Projects

Thoroughly read each commit. Ensure the commit message sufficiently explains the code by first checking that implementation matches the intent, ...

Writing Meaningful Commit Messages

This article discusses different methods of formatting and writing meaningful commit messages.

Write Better Git Commit Messages To Increase Your ...

5 Steps To Improve Your Git Messages · Capitalization and Punctuation: The first word should be capitalized and not end in punctuation. ·...

11 tips for writing a good Git commit message

Be descriptive and don't assume · Describe why a change is being made, not just what is changing · The first commit line...