question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Internal feeds should be disabled by default

See original GitHub issue
  • This issue is blocking
  • This issue is causing unreasonable pain

This is part of a larger effort to make public builds of recently open sourced internal fixes work better. Today there are two problems:

  • Customers want to build the shas we built, and if those shas were built internally, they have “darc-int” feeds in them. These feeds are not accessible externally. On release day, these feeds aren’t necessary. The packages have already been published to public locations (nuget.org). Often by the time a customer goes to build, these feeds don’t even have any packages.
  • The PRs opened to merge into the open have to be altered to remove the darc-int feeds, or otherwise the builds will fail.

The darc-int (and darc-pub, but those are public) feeds are added because they contain stable packages. To avoid the issues we see today, all darc-int feeds will be disabled by default in nuget.config files. Public builds of previously internal sources will work as expected on release day, and would fail prior (because not all packages are available). Today we have to run a script (SetupNuGetSources.ps1/sh) prior to building to add credentials for those feeds. This script will be altered to re-enable these sources if running on the internal AzDO project.

There are 3 parts to this change:

  • Arcade master, In SetupNuGetSources.ps1/sh, the script should identify the disabledPackageSources node. If it exists, find any darc-int feeds (use the same identification mechanism we use when adding credentials) and flip value="true" to value="false". If no darc-int feeds exist there, or the node does not exist, do nothing.
  • Arcade release/3.x, In SetupNuGetSources.ps1/sh, the script should identify the disabledPackageSources node. If it exists, find any darc-int feeds (use the same identification mechanism we use when adding credentials) and flip value="true" to value="false". If no darc-int feeds exist there, or the node does not exist, do nothing.
  • Maestro should add new functionality (and tests. there are already tests for manipulation of nuget.config) to add a “disabledPackageSources” node if it does not exist, and its contents should either be empty (but not <clear/>), or they should contain the source names of all darc-int sources, with the value="true" attribute.
<disabledPackageSources>
    <add key="darc-int-dotnet-core-setup-0c2e69ca" value="true" />
</disabledPackageSources>

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
MattGalcommented, Aug 13, 2020

Rolled out yesterday, will work on follow-up part today.

0reactions
MattGalcommented, Aug 10, 2020

With https://github.com/dotnet/arcade-services/pull/1334/files merged (checkbox 3), this goes to rollout.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Change Feeds Enabled By Default - Help
feeds are disabled by default for all my projects. This is expected behavior according to this documentation: Managing Activities Packages.
Read more >
Changes to Azure Artifacts Upstream Behavior
Today, we're excited to announce a new behavior that provides additional security for your private feeds by limiting access to externally ...
Read more >
Set Public and Private Visibility of Feed Items in Case ...
Agents can mark feed items public to make them visible to both internal and external users. Feed items marked private are visible only...
Read more >
Disable client RSS feeds
Guide to Sitecore client RSS feeds security and how to disable RSS feeds. ... Client RSS feeds are not disabled by default. Azure...
Read more >
Adding NSS Feeds for Web Logs
Status: The NSS feed is Enabled by default. Choose Disabled if you want to activate it at a later time. SIEM Destination Type:...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found