Please consider using `ExitWithExitCode 0` for failed builds only on Azure Pipelines
See original GitHub issueAs part of the https://github.com/dotnet/arcade/pull/6635 PR, the build scripts used by Arcade were updated to return a 0
exit code for build errors when the -ci
flag is specified. While the remark was made that it could break certain scenarios like CI builds made on GitHub Actions, it was assumed that -ci
meant Azure Pipelines
and no check was added to avoid using ExitWithExitCode 0
without considering the actual CI environment.
In the aspnet-contrib and OpenIddict projects, we use Arcade on GitHub Actions for our CI builds, and this change sadly broke us: https://github.com/openiddict/openiddict-core/issues/1546 (no need to say it wasn’t trivial to find why failed builds were reported as successful… 😄).
Is there a chance the suggested check could be added, so that the ExitWithExitCode 0
trick is only used on Azure Pipelines?
Issue Analytics
- State:
- Created 10 months ago
- Comments:8 (8 by maintainers)
Top GitHub Comments
thoughts @ChadNedzlek ?
Can someone from the Arcade team PTAL? This is really degrading the UX of our contributors. See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/pull/739#issuecomment-1353099136 for another very recent case.