[Publishing] Manifest versioning changes affecting darc-add-build-to-channel

• This issue is blocking
• This issue is causing unreasonable pain

NuGet.client ran into issues when using the add-build-to-channel command to insert one of their builds:

##[error].packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.20330.3\tools\SdkTasks\PublishArtifactsInManifest.proj(79,5): error : (NETCORE_ENGINEERING_TELEMETRY=Publish) This task is not able to handle legacy manifests.
(Build)

C:\dotnet\arcade [master ≡]> darc add-build-to-channel --id 56547 --channel "VS 16.7" --source-branch master
Build 56547 will be assigned to target channel(s) once this build finishes publishing assets: https://devdiv.visualstudio.com/devdiv/_build/results?buildId=3862000
Waiting '60' seconds for promotion build to complete.
Waiting '60' seconds for promotion build to complete.
Waiting '60' seconds for promotion build to complete.
Waiting '60' seconds for promotion build to complete.
Waiting '60' seconds for promotion build to complete.
Waiting '60' seconds for promotion build to complete.
Waiting '60' seconds for promotion build to complete.
The promotion build finished but the build isn't associated with at least one of the target channels. This is an error scenario. Please contact @dnceng.

I suspect https://github.com/dotnet/arcade/commit/5a99acb9c13bddf0174054c3b04c9cfff3fa8586 includes a change that causes NuGet’s manifest to be invalid when tring to publish using the command. This is a scenario that should still work.

As a workaround for now, specifying a source-sha parameter to use a commit before the publishing changes allows the build promotion job to succeed

darc add-build-to-channel --id 56547 --channel "VS 16.7" --source-branch "master" --source-sha "a7ba57554594196351a788410800fc6636cef16c"

@epananth We should find out what needs to happen to unblock this scenario. It’s possibly related to https://github.com/dotnet/arcade-services/pull/1261 which had to be reverted?

[riarenas]

Upgrading this to blocking. @epananth it looks like we need to allow older versions if possible.

[epananth]

@riarenas can you please work with @zivkan to get this PR merged? (I’m oof next week)