Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Warn PR author when eng/common is modified in consumer repo
See original GitHub issueIn arcade-powered repos, eng/common is logically a (readonly) mirror directory, which dotnet-maestro bot dutifully updates.
If a PR is submitted by a human being that updates a file under this directory, it is easy to misremember during the PR review. That causes a merge conflict in the next arcade update and mostly results in reverting the manual changes made earlier.
It would be nice if a bot post a comment to such PRs to help reminding reviewers about readonly-ness of eng/common, something to the effect:
Reminder:
eng/commonis a mirror directory. Please submit changes in dotnet/arcade repo to avoid conflicts during the subsequent arcade update.
ps: such reverts took place in dotnet/runtime repo few times, and currently eng/common in aspnetcore repo is diverged.
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@danmoseley This should be really easy to do with a GitHub Action that gets triggered by changes to eng/common, we’d just need to no-op for PRs from dotnet-bot i.e. legitimate updates. I’ll take a stab at it.
@akoeplinger I think you made the backport Github Action. do you know of any existing action that would do something like the above?