Ambigous route matches

Describe the bug

These two routes lead to an ambiguous match on Toyota-Corolla-vehicles/2.

    [HttpGet("{make}-{query}-vehicles/{makeId:int}")]
    [HttpGet("{make}-vehicles/{makeId:int}")]

According to my understanding, they shouldn’t as the two parameters are separated by a - which is a valid string literal. As per the docs, the routes match non greedily from right to left by comparing literals. the first route has two literals, the second route has only one literal, so I don’t see why it would be ambiguous when Toyota-Corolla-vehicles/2 contains two literals that match the first route in the form of - and -vehicles

To Reproduce

Add these routes to an action

    [HttpGet("{make}-{query}-vehicles/{makeId:int}")]
    [HttpGet("{make}-vehicles/{makeId:int}")]

Fire a get in the format

Toyota-Corolla-vehicles/2

[rynowak]

You can configure which one of these you want to be considered first with Order. https://docs.microsoft.com/en-us/aspnet/core/mvc/controllers/routing?view=aspnetcore-2.2#ordering-attribute-routes

[huysentruitw]

I’m not trying to defend the current implementation, the idea you have makes perfectly sense. However, I do think that it would make the route matching code more complex and probably slower (although the slowdown could be limited to figuring out the correct path in case of ambiguity). So let’s wait until someone from the core team joins this conversation.