question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[ANCM In-proc] Improve handling of malformed warmup requests

See original GitHub issue

Epic https://github.com/aspnet/AspNetCore/issues/8833

In some versions of Windows (RS1 or below), we get a malformed warm-up request that has missing data. We throw NullReferenceExceptions in that case, which is not ideal. We should investigate this further and try to make our logic more resiliant to these nulls, but only during these malformed warmup requests.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
analogrelaycommented, Apr 30, 2019

When this is done, consider backporting.

0reactions
jkotalikcommented, Jun 3, 2019

Acceptance checklist (check one item)

  • We decided not to take this fix.
  • The fix is tests-only.
  • The fix contains product changes (check all items below).
    • Relevant XML documentation comments for new public APIs are present.
    • Narrative docs (docs.microsoft.com) are updated. (check one item below)
      • The change requires a new article. An issue with an outline has been filed here: [ISSUE LINK]
      • The change requires a change to an existing article. A closed docs PR with these changes is linked here: [PR LINK]
      • The change requires no docs changes.
    • Verification has been completed. (check one item below)
      • The change is in the shared framework and was verified against the following versions
        • SDK installer: 3.0.100-preview6-012113
        • ASP.NET Core Runtime: 3.0.0-preview6-19279-01
        • .NET Core Runtime: 3.0.0-preview6-27728-04
      • The change is in an OOB NuGet/NPM/JAR package and was verified against the following version of that package: [PACKAGE ID] [VERSION]
Read more comments on GitHub >

github_iconTop Results From Across the Web

[Epic] ANCM Improvements · Issue #8833 · dotnet/aspnetcore
[ANCM In-proc] Improve handling of malformed warmup requests #9873 [ANCM In-proc] Improve handling of malformed warmup requests
Read more >
How to fix error "ANCM In-Process Handler Load Failure"?
I'm setting up the first site in IIS on Windows Server 2016 Standard. This is a NET Core 2.2 application. I cannot get...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found