question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Apply API Review feedback to JsonHubProtocolOptions

See original GitHub issue

Specifically, we should review the JsonHubProtocolOptions for the new System.Text.Json based protocol.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
BrennanConroycommented, May 3, 2019

Those are the defaults set by new JsonSerializerOptions(); I’m not setting 0 or 64. The ask is do we want to set these, or keep the defaults?

0reactions
BrennanConroycommented, May 28, 2019

Acceptance checklist (check one item)

  • We decided not to take this fix.
  • The fix is tests-only.
  • The fix contains product changes (check all items below).
    • Relevant XML documentation comments for new public APIs are present.
    • Narrative docs (docs.microsoft.com) are updated. (check one item below)
      • The change requires a new article. An issue with an outline has been filed here: [ISSUE LINK]
      • The change requires a change to an existing article. A closed docs PR with these changes is linked here: [PR LINK]
      • The change requires no docs changes.
    • Verification has been completed. (check one item below)
      • The change is in the shared framework and was verified against the following versions
        • SDK installer: [3.0.100-preview6-012096]
        • ASP.NET Core Runtime: [3.0.0-preview6-19277-03]
        • .NET Core Runtime: [3.0.0-preview6-27727-02]
      • The change is in an OOB NuGet/NPM/JAR package and was verified against the following version of that package: [PACKAGE ID] [VERSION]
Read more comments on GitHub >

github_iconTop Results From Across the Web

Apply API Review feedback to JsonHubProtocolOptions
Specifically, we should review the JsonHubProtocolOptions for the new System.Text.Json based protocol.
Read more >
How to publish reviews/responses with the API on your ...
With the ReviewPro API you have full control over the way published reviews and responses are shown on your website. With the API...
Read more >
Feedback API quick guide
Feedback API. To start using the Feedback interface, you can upload translation incidents feedback for review via the Feedback API.
Read more >
Reviews : Swarm Reviews
API responses honor these private project restrictions. ... Use true or false for JSON-encoded data, 1 for true and or 0 for false...
Read more >
REST Resource: accounts.locations.reviews
Google Business Performance API has a NEW API method that allows fetching multiple `DailyMetrics` in a single API request. Review the deprecation schedule...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found