Changing the date / time format reflect to the CurrentCulture all the time

Background and Motivation

Changing the culture date/time format reflect to the default culture, there’s no way in the current APIs to allow the user doesn’t rely on the system settings

Proposed API

+ private readonly bool _useUserOverride;
+
    private RequestCulture _defaultRequestCulture =
        new RequestCulture(CultureInfo.CurrentCulture, CultureInfo.CurrentUICulture);

- public RequestLocalizationOptions()
+ public RequestLocalizationOptions() : this(useUserOverride: true)
{
-    RequestCultureProviders = new List<IRequestCultureProvider>
-    {
-        new QueryStringRequestCultureProvider { Options = this },
-        new CookieRequestCultureProvider { Options = this },
-        new AcceptLanguageHeaderRequestCultureProvider { Options = this }
-    };
}

+ public RequestLocalizationOptions(bool useUserOverride)
+{
+    _useUserOverride = useUserOverride;
+    RequestCultureProviders = new List<IRequestCultureProvider>
+    {
+        new QueryStringRequestCultureProvider { Options = this },
+        new CookieRequestCultureProvider { Options = this },
+        new AcceptLanguageHeaderRequestCultureProvider { Options = this }
+    };

Usage Examples

var options = new RequestLocalizationOptions(useUserOverride: true);

app.UseRequestLocalization(options);

Alternative Designs

Risks

[halter73]

You need to update PublicAPI.Unshipped.txt instead of PublicAPI.Shipped.txt. We generally only update the PublicAPI.Shipped.txt files once a year after we’ve shipped new APIs as part of a major release. You can read more about these files in our API Baselines doc.

As suggested in that doc, you can apply the RS0016 code fix in VS to update PublicAPI.Unshipped.txt automatically. If it doesn’t work out for you, just try making the actual code change and we can update PublicAPI.Unshipped.txt for you.

[halter73]

@hishamco It wasn’t just me that decided on CultureInfoUseUserOverride. Members of @dotnet/aspnet-api-review had a vote and approved it. We discussed your UseSystemCultureSettings and UseUserOverrideCulture naming suggestions, but we still prefer CultureInfoUseUserOverride. If you want us to merge your PR, it must match the approved API.