Consider JavaScript files as binary in .gitattributes

Is your feature request related to a problem? Please describe.

Very often in this repository, the jQuery JavaScript library is referenced in HTML files with SRI (Subresource Integrity), meaning that a hash of the file is provided as an attribute. Therefore it is crucial that JavaScript files are not modified when pushed to the repository. Git settings like core.autocrlf (defaults to true under Git tools for Windows) can therefore cause issues that are not immediately noted. The more SRI we use, the more often this problem might occur.

Describe the solution you’d like

If *.js files would be considered as binary in ´.gitattributes´, they should not be altered when being pushed to the repository.

Additional context

Suggested fix: add *.js binary in .gitattributes

[wenz]

ah, our replies overlapped 😉 Yes, just “hardcoding” jquery.js and jquery.min.js into .gitattributes might be even better since it only affects those libraries where we are actually using SRI currently. Probably jquery*.js eol=lf is good enough (subject to verifying that it works)?

[SteveSandersonMS]

I see, thanks for clarifying. So we do hard-code hashes in our sources 😃 In that case I agree it’s problematic to allow CRLF conversion for those files.

However like @javiercn points out, we wouldn’t want to set .gitattributes to treat every single .js file in the repo as binary, since that would break our normal workflows for seeing diffs for .js files that we do actually edit. Instead, I suggest there should be more targeted .gitattributes rules pointing just to the exact problematic files (or perhaps narrow this rule down to files called jquery.js anywhere in the repo).