Enable IDE0005 analyzer in the build

See the conversation in https://github.com/dotnet/aspnetcore/pull/47540#issuecomment-1523799428. In order to unblock updating the SDK, I needed to add dotnet_diagnostic.EnableGenerateDocumentationFile.severity = none to the .globalconfig file. The new SDK was breaking the build for projects that don’t have GenerateDocumentationFile=true.

We should figure out how to enable GenerateDocumentationFile=true for non product assemblies.

@sharwell suggested adding:

  <PropertyGroup>
    <!--
      Make sure any documentation comments which are included in code get checked for syntax during the build, but do
      not report warnings for missing comments.
      CS1573: Parameter 'parameter' has no matching param tag in the XML comment for 'parameter' (but other parameters do)
      CS1591: Missing XML comment for publicly visible type or member 'Type_or_Member'
      CS1712: Type parameter 'type_parameter' has no matching typeparam tag in the XML comment on 'type_or_member' (but other type parameters do)
    -->
    <GenerateDocumentationFile>True</GenerateDocumentationFile>
    <NoWarn>$(NoWarn),1573,1591,1712</NoWarn>
  </PropertyGroup>

I think we should only set those NoWarn for non-product level assemblies. So we need to do some build logic to ensure those doc warnings still occur for product projects that have public API.

More info at:

• https://github.com/dotnet/roslyn/pull/58835
• https://github.com/dotnet/roslyn/issues/41640

[scottkuhl]

It may have been marked as fixed, but I’m on the latest version of 7 and it still exists.

[ryanbuening]

I just updated my Visual Studio to 17.7 GA and am now seeing this issue in my .NET 7 project when building.

Removing dotnet_diagnostic.IDE0005.severity = error from the .editorconfig fixes it.