question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move IServerVariables feature and friends to Http.Abstractions

See original GitHub issue

The IIS server adds an HTTP feature IServerVariablesFeature. Server Variables are not an IIS-exclusive concept and date all the way back to CGI so it seems reasonable that a server may want to provide them. We should move this type out of Servers.IIS and in to HttpAbstractions.

Specific changes:

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
Tratchercommented, May 11, 2019

Type forwarding IServerVariablesFeature would be compatible, no? Unless you change the namespace.

GetIISServerVariables can stay for compat, GetServerVariables would be a new extension method. Note GetServerVariables does not go in Http.Features, it would go into Http.Extensions.

0reactions
jkotalikcommented, Jul 1, 2019

Acceptance checklist (check one item)

  • We decided not to take this fix.
  • The fix is tests-only.
  • The fix contains product changes (check all items below).
    • Relevant XML documentation comments for new public APIs are present.
    • Narrative docs (docs.microsoft.com) are updated. (check one item below)
      • The change requires a new article. An issue with an outline has been filed here: [ISSUE LINK]
      • The change requires a change to an existing article. A docs PR with these changes is linked here: [PR LINK]
      • The change requires no docs changes.
    • Verification has been completed. (check one item below)
      • Verified against ASP.NET Core App Version 3.0.0-preview7.19351.2
Read more comments on GitHub >

github_iconTop Results From Across the Web

Move IServerVariables feature and friends to Http. ...
The IIS server adds an HTTP feature IServerVariablesFeature. ... Move IServerVariables feature and friends to Http.Abstractions #10167.
Read more >
Microsoft.AspNetCore.Http.Features split up - .NET
Http.Features package has been split, and no longer ships as a package. ... The following types have been moved to the new Microsoft....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found