Possible incorrect sorting in KnownHeaders.cs

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Hello,

Looks like there are some incorrect sorting operations in KnownHeader.cs.

Perhaps, there should be the .OrderBy(...).ThenBy(...) invocation sequence instead of .OrderBy(...).OrderBy(...).

The first case:

....
.Concat(corsRequestHeaders)
.OrderBy(header => header)
.OrderBy(header => !requestPrimaryHeaders.Contains(header))
.Select((header, index) => new KnownHeader
....

The second case:

....
.Concat(corsResponseHeaders)
.OrderBy(header => header)
.OrderBy(header => !responsePrimaryHeaders.Contains(header))
.Select((header, index) => new KnownHeader
....

The third case:

....
.OrderBy(header => header)
.OrderBy(header => !responsePrimaryHeaders.Contains(header))
.Select((header, index) => new KnownHeader
....

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

[adityamandaleeka]

There isn’t a bug here; OrderBy does a stable sort and the second OrderBy in these cases just checks for presence in a set, so we always end up with the same result (specifically, one where the headers are in order and the primary ones come first).

I suppose it would be slightly cleaner for us to first sort on set presence, then use ThenBy to sort by header which would accomplish the same thing.

[adityamandaleeka]

Closed with https://github.com/dotnet/aspnetcore/pull/40410