Some tests are broken on Net 461 (culture-dependent thing)
See original GitHub issuemaster branch, VS 2017 15.9.6, target net461, current UI culture is ‘ru-RU’
Some tests are failing under both VS & Resharper test runners, first few of them:
-
Tests AllSetupAndCleanupMethodRunsAsyncGenericValueTaskSetupTest, AllSetupAndCleanupMethodRunsAsyncValueTaskSetupTest AnArrayCanBePassedToBenchmarkAsSpan ArgumentsArePassedToBenchmarks TaskReturningMethodsAreAwaited UserCanSpecifyCustomBuildConfiguration
benchmark build fails with message
error CS0012: The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
-
Tests
WhenInvalidCommandLineArgumentIsPassedAnErrorMessageIsDisplayedAndNoBenchmarksAreExecuted
UnknownConfigMeansFailure
fail with ArgumentNullException.
-
Test CanDisassembleInlinableBenchmarks, error ‘Assert.Contains() Failure Not found: (filter expression)’
-
Tests from LocalCoreClrToolchainTests, LocalCoreRtToolchainTests error ‘System.IO.DirectoryNotFoundException : C:\Projects\corert\bin\Windows_NT.x64.Release provided as newIlcPath does NOT exist’
etc
Issue Analytics
- State:
- Created 5 years ago
- Comments:6 (6 by maintainers)
@ig-sinicyn in BDN we always do everything in Release, so honestly, I am not worried about the Debug builds. If you would like to make it work in Debug I would be very happy to review the PR :d
@adamsitnik some tests still fail for debug builds, CanDisassembleInlinableBenchmarks as example. Is it ok?