Wrong favicon.ico in _site

Title

Wrong favicon.ico in _site

Functional impact

The generated _site contains the wrong favicon.ico when _appFaviconPath is specified in docfx.json.

Minimal repro steps

1. Add your own favicon.ico to ./images
2. Add _appFaviconPath to docfx.json

Expected result

My ./images/favicon.ico should be copied to _site.

Actual result

The default docfx favicon.ico is copied to _site.

[superyyrrzz]

@smaillet Thank you for your comments and it’s really convincing. It makes sense for content to overwrite template. I will fix it. @emrgee After the fix, _appFaviconPath is not needed. Adding a resource is sufficient:

"resource": [
  {
    "files": ["favicon.ico"]
  }
]

[paulushub]

@moxy524 See an example of how it is done here https://github.com/ElinamLLC/SharpVectors/tree/master/docfx

The result here https://elinamllc.github.io/SharpVectors/index.html