Non-nullable shadow property problem

Hi there,

If I specify a string property in an entity type class as

        public string Test2 { get; set; } = null!;

it gets correctly picked up as non-null ("Test2" TEXT NOT NULL) in the create statement.

If I specify the same property as a shadow property via

            modelBuilder
                .Entity<MyEntity>()
                .Property<string>("Test1");

it is nullable ("Test1" TEXT NULL) in the create statement.

This seems like a bug or am I doing something wrong?

Further technical details

EF Core version: 5.0.0-preview.8.20407.4 Database provider: Sqlite Target framework: .NET Core 3.1 latest (nullable enabled) Operating system: Windows 10 latest IDE: Rider latest

[markm77]

Hey thanks @roji , great info! I see NRT as following the TypeScript model where you allow compile-time and run-time languages to diverge to add new features without modifying the run-time language. However I do hope at some point the run-time language (CLR) is updated to natively support NRT as this would simplify the whole feature and avoid increasing use of reflection which is not great for performance/debugging/analyzers/etc. Just my thoughts, have a great day!

[roji]

Not sure there is anything to do here… For shadow properties specifically, as written above, the runtime Type for generic type parameters lacks NRT information (by design). For non-shadow generic properties, our current NRT metadata decoding indeed doesn’t support them because of the complexities involved. However, using the new .NET decoder should fix this - already tracked by #24744.