Not Disposing SqlCommand or SqlDataReader on Caching.SqlServer

Describe the bug

We are being hit at least weekly with this issue filed in corefx.

Going through the source code of the Caching.SqlServer package I notice that some classes that implement IDisposable are not wrapped in a using block.

https://github.com/aspnet/Extensions/blob/f2ef1b55d65feac6ad4e3dd8b04daa21f464631b/src/Caching/SqlServer/src/DatabaseOperations.cs#L215-L227

In this snippet both SqlCommand and the SqlDataReader implement IDisposable but they are not disposed, and looking at their implementation it looks like they are actually doing some clean up work:

https://github.com/dotnet/corefx/blob/a53ada190e2e0bd229e76ae4a6d45c13a986ab18/src/System.Data.SqlClient/src/System/Data/SqlClient/SqlCommand.cs#L777-L785

https://github.com/dotnet/corefx/blob/a53ada190e2e0bd229e76ae4a6d45c13a986ab18/src/System.Data.SqlClient/src/System/Data/SqlClient/SqlDataReader.cs#L773-L793

Is there a particular reason why this is not done?

[epignosisx]

I submitted a PR that was merged, but it will not be available until 3.0.

The truth is I don’t know if this fix will actually resolve the issues we’ve been having in production.

Also, the fact that no one else have reported this makes it look it’s a problem on my side, rather than the framework, but at the same time we interact with other DBs and we have not run into this problem (following the recommendation of disposing of all ADO.NET objects).

I would really like to hear from you if this issue comes up. Maybe then, @tratcher will consider it for a servicing release.

I’m going to close this issue because the PR was accepted.

[muratg]

@JunTaoLuo could you take a look please (the PR is linked.)