Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove unclear FakeTimeProvider.Advance() overload

See original GitHub issue

I am not a fan of the Advance() overload method on FakeTimeProvider that does not take a TimeSpan and just increments time with 1ms. It is not obvious to the dev/user and is likely going to cause confusion to some.

I suggest removing it. If specific teams like the overload, they can easily add it back in via an extension method.

Issue Analytics

State:
Created 4 months ago
Comments:12 (12 by maintainers)

Top GitHub Comments

1reaction

danmoseleycommented, May 31, 2023

I don’t think it matters much at this point as if we end up supporting this publicly it will go through api review. Feel free to leave it out but I would have the extension method.

1reaction

danmoseleycommented, May 31, 2023

and maybe add an extension method Advance() just for this codebase.