Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update AddTransientHttpErrorPolicy once Polly v7 is released

See original GitHub issue

I’m not sure if you are already aware of this, but Polly v7 will distinguish between RetryPolicy and AsyncRetryPolicy. Since all methods on the HttpClient are async, it would make sense if AddTransientHttpErrorPolicy only accepted AsyncPolicy (note: not IAsyncPolicy since the sync version of RetryPolicy also implements that interface for some weird reason).

https://github.com/App-vNext/Polly/wiki/Polly-v7-breaking-changes

Issue Analytics

State:
Created 5 years ago
Comments:19 (8 by maintainers)

Top GitHub Comments

2reactions

rynowakcommented, Feb 21, 2019

I’ll catch up with @glennc and discuss with him. I can’t think of a reason why we wouldn’t do this. We want users to get the best version of things.

1reaction

rynowakcommented, Apr 2, 2019

This is done!

Top Results From Across the Web

Update AddTransientHttpErrorPolicy once Polly v7 is ...

No changes to AddTransientHttpErrorPolicy(...) will be necessary to take advantage of Polly v7 cleaning up the sync/async split in Polly.

PollyHttpClientBuilderExtensions. ...

The policy builder will be preconfigured to trigger application of the policy for requests that fail with conditions that indicate a transient failure....

Microsoft.Extensions.Http.Polly 7.0.10

Version Downloads Last updated 8.0.0‑preview.7.23375.9 6,179 12 days ago 8.0.0‑preview.6.23329.11 8,450 a month ago 8.0.0‑preview.5.23302.2 6,267 2 months ago

Polly + API Services That Return Errors as Results

AddTransientHttpErrorPolicy will check the followings: 408 Timeout; 5xx Server error; HttpRequestException. So as you can see neither 400, 404, ...

The CORRECT way to implement Retries in .NET - YouTube

I've been using Polly for a long time. One of the things you have to be careful of though is when making HttpRequests...