Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve AppVersion single project manifest support

See original GitHub issue

We need to update the targets/logic to this spec:

Application Version

<ApplicationVersion>1</ApplicationVersion>
iOS: CFBundleVersion
Android: android:versionCode
WinUI: //Package/Identity[@Version] Only if ApplicationDisplayVersion not set
Must be validated as an integer (iOS supports x.y.z but we are forcing a lowest common denominator here)

Application Display Version

<ApplicationDisplayVersion>1.0.0</ApplicationDisplayVersion>
iOS: CFBundleShortVersionString
Android: android:versionName
WinUI: //Package/Identity[@Version] (supercedes ApplicationVersion)
Must be validated as a x.y.z version string

Issue Analytics

State:
Created 2 years ago
Comments:22 (21 by maintainers)

Top GitHub Comments

1reaction

jonathanpepperscommented, Aug 11, 2021

Ok, makes sense, maybe the final defaults are:

<PropertyGroup>
  <ApplicationVersion Condition=" '$(ApplicationVersion)' == '' ">1</ApplicationVersion>
  <Version Condition=" '$(ApplicationDisplayVersion)' != '' ">$(ApplicationDisplayVersion)</Version>
  <ApplicationDisplayVersion Condition=" '$(ApplicationDisplayVersion)' == '' ">$(Version)</ApplicationDisplayVersion>
</PropertyGroup>

1reaction

vhugogarciacommented, Jul 24, 2021

@vhugogarcia you can use Condition to do whatever you need on different TFMs. For example:
<ApplicationVersion Condition="$(TargetFramework.Contains('android'))">1</ApplicationVersion>

<ApplicationVersion Condition="$(TargetFramework.Contains('ios'))">1.0.0</ApplicationVersion>

That is sooo cool!! Perfect then 💪🏻. Thanks for sharing it.