Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Ensure green test runs in VS

See original GitHub issue

Issue Description

Running unit tests in VS leads to some test failures - this should not be a case. VS-centric developer workflow should not be neglected

Classes of problems to tackle:

Tests using ExecMSBuild fail on core: https://github.com/dotnet/msbuild/issues/8313

(Reported by @vlada-shubina) Some BuildEnvironmentHelper_Tests fail on core (extra RID in path) - https://github.com/dotnet/msbuild/pull/8348

Shouldly.ShouldAssertException : BuildEnvironmentHelper.Instance.MSBuildToolsDirectory32
    should be
"C:\Users\jankrivanek\AppData\Local\Temp\lhywa2vr.vir\2dfce9d58278472ea474ec9359cd7edd\MSBuild\Current\Bin"
    but was
"C:\Users\jankrivanek\AppData\Local\Temp\lhywa2vr.vir\2dfce9d58278472ea474ec9359cd7edd\MSBuild\Current\Bin\amd64"

Tests marked with TestPlatforms.AnyUnix run on Windows (and can fail). Can we use https://github.com/xunit/xunit/issues/2073 here? - https://github.com/dotnet/msbuild/pull/8348
Test marked with SkipOnTargetFramework run on excluded FW (and can fail) Can we use https://github.com/xunit/xunit/issues/2073 here? - https://github.com/dotnet/msbuild/pull/8348

StringTool RetainsLastStringWithGivenHashCode: #8340

Shouldly.ShouldAssertException : _cache.GetDebugInfo()
   should be
Microsoft.NET.StringTools.WeakStringCache+DebugInfo (-1703002807)
    but was
Microsoft.NET.StringTools.WeakStringCache+DebugInfo (-1703002806)

ProjectItemSpecTooLong (might be env setup on my machine) - related? https://github.com/dotnet/msbuild/issues/4247
ProjectGetterResultsInWindowsDriveEnumerationWarning on Win (might be path specific?) - fixed by https://github.com/dotnet/msbuild/issues/7330
LogWarningUponProjectInstanceCreationFromDriveEnumeratingContent & LogWindowsWarningUponProjectInstanceCreationFromDriveEnumeratingContent (env specific?) - https://github.com/dotnet/msbuild/issues/7330
EvaluationProfiler_Tests (all) - no repro. (might have been caused by the bug in not unsetting the reverted change waves in tests)
LogWindowsWarningUponBuildingProjectWithDriveEnumeration - likely just needs application of the following fix: https://github.com/dotnet/msbuild/pull/8366

Issue Analytics

State:
Created 8 months ago
Reactions:2
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

vlada-shubinacommented, Jan 24, 2023

https://github.com/dotnet/msbuild/pull/8348 solves # 2, 3 and 4 in the list, and likely other cases as well. The Unix only cases will be skipped in VS now, as the tests running on unsupported framework. This should reduce number of red tests in VS.

0reactions

vlada-shubinacommented, Feb 16, 2023