GenerateCompiledExpressionsTempFile does not clean up the files it creates

1. Create a new .NET Framework project
2. Build
3. Clean

Expected: Obj to be empty Actual: 3 files generated by GenerateCompiledExpressionsTempFile are still present:

TemporaryGeneratedFile_036C0B5B-1481-4323-8D20-8F5ADCB23D92.cs
TemporaryGeneratedFile_5937a670-0e60-4077-877b-f7221da3dda1.cs
TemporaryGeneratedFile_E7A71F73-0F8D-4B9B-B56E-8E70B10BC5D3.cs

[rainersigwald]

Is it a livable situation if we do not use Workflow (I do not believe we do; but maybe there is something I am missing here)

I think the breakage is limited to the Workflow designer, but I’m not totally confident in that.

your fixes on the Long Path

Can’t take much credit for this; ccastanedaucf did the actual work there. Also note that the changes there don’t apply inside VS so you’re likely to continue to need output-path gymnastics for a while yet.

[aolszowka]

When you say “Break VS” what do you mean? Is it a livable situation if we do not use Workflow (I do not believe we do; but maybe there is something I am missing here). I just tested it and as far as I can tell I am getting an incremental build now.

Thank you for all the hard work you’ve been doing your fixes on the Long Path are also fixing another issue that we’re encountering wherein the state files previously were not being written (we’re working around that too by putting our IntermediateOutputPath basically in to the root of the C Drive and then flattening it out from there). Long term we just need to get to VS19/MSB16, because it includes tons of these changes I know, but this is just absolutely killing us (60 Devs; 200 in the whole company).