question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[LiveLogger] Plug the logger into minimum message importance checks

See original GitHub issue

As a perf optimization MSBuild can filter out verbose log output very early to speed up the build if no logger interested in low importance messages is enabled. LiveLogger is currently not recognized by this system, making it slower than the default console logger as configured in dotnet build.

It should be as simple as adding a case here: https://github.com/dotnet/msbuild/blob/dfd8f413a80cd0865f968b2c0ad9b09c0df8c430/src/Build/BackEnd/Components/Logging/LoggingService.cs#L1630-L1644

Needless to say, LL must not actually consume any low importance messages for this to work.

Issue Analytics

  • State:closed
  • Created 7 months ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
rainersigwaldcommented, Feb 21, 2023

I think I would be comfortable with a string match on a fully-qualified type name in the code block in the OP.

0reactions
AR-Maycommented, Feb 21, 2023

I think I would be comfortable with a string match on a fully-qualified type name in the code block in the OP.

Not a big fan of it, but it is a good enough hack for me, i think. I still would like to put some thought into LiveLogger location.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Logging HOWTO — Python 3.11.4 documentation
setLevel() specifies the lowest-severity log message a logger will handle, where debug is the lowest built-in severity level and critical is the highest...
Read more >
Python Logging Levels Explained
Level: The level determines the minimum priority level of messages to log. Messages will be logged in order of increasing severity: DEBUG is...
Read more >
Python Logging Best Practices: The Ultimate Guide
Read about Python logging best practices and how to get the best log monitoring setup for your organization. Learn what Python logging is ......
Read more >
Logger (Java Platform SE 8 )
A Logger object is used to log messages for a specific system or application component. Loggers are normally named, using a hierarchical dot-separated ......
Read more >
Node.js Logging with Winston
Log level is the piece of information in our code that indicates the importance of a specific log message. Using appropriate log levels...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found