Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

NB.GV defeats incremental build for .NET SDK style WPF projects

See original GitHub issue

Nerdbank gitversion is incompatible with WPF targets and SDK projects. Either ThisAssembly will be inaccessible due to protection level, or the generation of Version.cs in the WPF temp project breaks incremental build.

From my investigation, I believe 3 things are needed:

Make GenerateAssemblyVersionInfo run before MarkupCompilePass1
Do not run GenerateAssemblyVersionInfo inside the WPF temporary project.
Re-include the Version.cs generated from the original project in the WPF temporary project.

See https://devdiv.visualstudio.com/DevDiv/VS IDE CPS/_git/CPS/pullrequest/120052?_a=overview for the workarounds I performed to get this to work.

Issue Analytics

State:
Created 5 years ago
Comments:8 (1 by maintainers)

Top GitHub Comments

1reaction

clairernovotnycommented, May 18, 2018

@AArnott FWIW, the SDK Extras 1.5.4 includes a fix for the WPF imports stuff based on a new variable they set.

0reactions

jviaucommented, May 2, 2018

I updated my comment above. I debugged into MarkupCompilePass1, and its incremental build check always failed when checking the timestamp of Version.cs. The fix I linked of ensuring Version.cs is created before wpf targets run, and then not generating that file within the wpf temp proj resolved it for me.